Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZeroVec::take_last and ::take_first #4651

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

sffc
Copy link
Member

@sffc sffc commented Mar 5, 2024

I did not end up needing these functions but if we think they are good to have we can merge them.

@sffc sffc requested a review from Manishearth as a code owner March 5, 2024 08:14
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

into_cow() succeeds as a building block once again

@sffc
Copy link
Member Author

sffc commented Mar 5, 2024

@srl295 CLA bot is broken again

@robertbastian robertbastian reopened this Mar 6, 2024
@Manishearth Manishearth merged commit db1772d into unicode-org:main Mar 6, 2024
58 checks passed
@sffc sffc deleted the zv_first branch March 6, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants